[
https://issues.apache.org/jira/browse/SLING-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667186#action_12667186
]
Felix Meschberger commented on SLING-839:
-----------------------------------------
Thanks for supplying this patch. I would really like to integrate this with
Sling.
Before I can apply it though, there are some missing pieces to be resolved.
* Some licensing stuff is missing: The Java and JSP scripts need the ASF
headers, the NOTICE must list all third party providers (e.g. IBM of icu4j) and
the must be license files for the third party non-ASL2 libraries included in
the bundle.
* It looks like the Eclipse Higgins libraries are not available from any
repository. Are they really required ?
* I have no deeper knowledge about the openid4java project, but the dependency
list really scares me. Is it required to include spring-jdbc and icu4j and all
this XML stuff ? Just building the package weighs in at 8.5MB, which looks like
a bit heavy to just do authentication ... I may be the only one here, though ;-)
* Do I understand it correctly, that your module contains an OpenID consumer to
be used as a Sling AuthenticationHandler and an OpenID provider
(TestOpenIDServer) ?
Wouldn't it make more sense to split the functionalities ? To have an
openid-consumer module and an openid-provider module ? I think both make
perfect sense. But I think, the consumer module should be lean and mean while
the provider module may be heavy-weight.
Have you looked into http://code.google.com/p/dyuproject/ which seems to have a
very light-weight consumer (relying party).
> OpenID AuthenticationHandler
> ----------------------------
>
> Key: SLING-839
> URL: https://issues.apache.org/jira/browse/SLING-839
> Project: Sling
> Issue Type: New Feature
> Components: Engine, Extensions, General
> Reporter: Rory Douglas
> Priority: Minor
> Attachments: openidauth.zip
>
>
> An implementation of AuthenticationHandler for authenticating users against
> OpenID providers. Includes basic UI for login & logout.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
