[
https://issues.apache.org/jira/browse/SLING-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674822#action_12674822
]
Alexander Klimetschek commented on SLING-571:
---------------------------------------------
@Felix: I think I removed the "Stacktrace:" strings because they looked "ugly"
in the output and it was somewhat obvious that these are stacktraces or the
word stacktrace was duplicated in the end. Unfortunately I don't have the
original testing situation anymore - I think it was something nasty like a jsp
compile exception in the 404 error handler.
@Carsten: I will take a look at it. Basically it should be the 4 points
mentioned in my comment for the third patch, probably without the removal of
the "Stacktrace:" strings if you favor them.
> JspServletWrapper swallows jsp exceptions if root cause is null
> ---------------------------------------------------------------
>
> Key: SLING-571
> URL: https://issues.apache.org/jira/browse/SLING-571
> Project: Sling
> Issue Type: Bug
> Components: Scripting JSP
> Affects Versions: Scripting JSP 2.0.2
> Reporter: Tobias Bocanegra
> Assignee: Carsten Ziegeler
> Fix For: Scripting JSP 2.0.4
>
> Attachments: SLING-571-reloaded.patch, SLING-571-third.patch,
> SLING-571.patch
>
>
> For example for a JSP compile error the 'realException' is null and the
> following stack-frame resolution fails:
> (JspServletWrapper.java, line 492ff)
> // First identify the stack frame in the trace that represents
> the JSP
> StackTraceElement[] frames = realException.getStackTrace();
> StackTraceElement jspFrame = null;
> for (int i=0; i<frames.length; ++i) {
> if (
> frames[i].getClassName().equals(this.getServlet().getClass().getName()) ) {
> jspFrame = frames[i];
> break;
> }
> }
> Suggest to check for (realException == null)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
