[
https://issues.apache.org/jira/browse/SLING-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696000#action_12696000
]
Felix Meschberger commented on SLING-845:
-----------------------------------------
The problem is, that when redoing the launchpad launcher code, I completely
disabled support for system properties to be used as framework properties for
the Sling web application. The reason for this is, that a web application runs
in a container and that muliple sling web applications may be running in the
same servlet container. If all would be using system properties for
configuration, they would in fact all use the same configuration, which may not
be desired.
An at least partial solution is to have jetty:run provide the sling.home
property to the web app. Starting with the maven jetty plugin 6.1.6 (we
currently use 6.1.5), there is a new configuration option, which allows
injecting context initial parameters. By injecting the sling.home context init
param, we can provide the required property.
One thing, which remains to be fixed are the integration tests, which use the
Maven Cargo plugin to launch a Jetty instance and deploy the Sling web app into
it. The solution here might be to hook into the maven build lifecycle with our
own setup:
pre-integration-test: Launch the Sling standalone application in a separate
process, providing the sling.home
property as well as the port to use
post-integration-test: Shutdown the started Sling standalone application by
either killing the process (if possible)
or sending a POST request to the Web Console to shutdown (this is
possible with the new launcher in
that stoping the system bundle also terminates the Sling
standalone application).
In Rev. 762238 updated the parent pom referring to version 6.1.6 of the jetty
plugin and in Rev. 762239 adapted the launchpad/webapp project to inject the
parameter.
> Full build with integration test leaves sling folder in root
> ------------------------------------------------------------
>
> Key: SLING-845
> URL: https://issues.apache.org/jira/browse/SLING-845
> Project: Sling
> Issue Type: Bug
> Components: Launchpad
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Attachments: patch-clean-sling-dir.txt
>
>
> When running a full build from trunk root including the integration tests,
> the sling directory used by the integration test web app is placed in the
> root folder. It would be better if this directory would be located in the
> target folder of the launchpad/testing module.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
