Excellent :),
Thank you,
I should be able to refactor our JR 14 access manager onto this quite
easily.
One question,
I see its all or nothing, if the plugin is there isGranted doesnt look
at the default.
I was wondering if there was a way of checking the default, and then
checkin the plugin, knowing the defaults response. That way the plugin
could enhance the default ACM where possible. (ie chain)
eg
public boolean isGranted(Path absPath, int permissions) throws
RepositoryException {
if (this.sanityCheck()) {
- return
this
.accessManagerPlugin.isGranted(namePathResolver.getJCRPath(absPath),
permissions);
+ return
this
.accessManagerPlugin.isGranted(namePathResolver.getJCRPath(absPath),
permissions,super.isGranted(absPath, permissions));
} else {
return super.isGranted(absPath, permissions);
}
}
?
also
There appear to be some public methods that don't delegate to the
plugin.
like
+ public boolean isGranted(Path parentPath, Name childName, int
permissions) throws RepositoryException {
+ return super.isGranted(parentPath, childName, permissions);
+ }
and checkPermission
was that intentional ?
Ian
On 24 Apr 2009, at 08:45, Vidar Ramdal wrote:
I applied the patch yesterday, so the feature is now available in the
trunk. Let me know if something is unclear.
