On Fri, Apr 24, 2009 at 9:18 PM, Aaron Zeckoski <[email protected]> wrote: > ...I am pretty sure the code is being exercised by the > integration tests since they are all working but I would be more > comfortable if there were unit tests in place as well.
Agree 100%, go for it! > ... It would make > the patch much bigger though so it might be something that the > community would prefer not happen. What are the options/policies here?... Somewhat larger patches are not a problem as long as they are "atomic", i.e. each patch should fix/implement one thing only, or a closely related and consistent set of things. This allows us to accept/improve/reject each patch individually. Automated tests clearly belong to the patch that they test. -Bertrand
