On Wed, May 6, 2009 at 5:33 PM, Carsten Ziegeler <cziege...@apache.org> wrote:
> ...I redid the release, which is not version 5 and we can vote again :)...
I guess you mean *now* version 5 ;-)
+1 on the release, details below.
Signatures and digests verified. Tests with Maven version: 2.0.9, Java
version: 1.5.0_16
on macosx 10.5.6.
> sling-5-incubator-source-release.tar.gz
> 2d3f26b986b12e4c3863c8352508cc6c
>
> sling-5-incubator-source-release.zip
> e60241ee568f76872684348690b069d5
Checked that those contain the exact same files.
That source builds with "mvn clean install" after deleting the
org/apache/sling in my local maven repository, but on my first build
two tests failed in JspForwardTest (test result attached). Tried two
more builds with no errors, didn't investigate more.
> The launchpad app:
> org.apache.sling.launchpad.app-5-incubator-bin.tar.gz
> bce9be4df9de0bb8e3f856dc83034fdb
>
> org.apache.sling.launchpad.app-5-incubator-bin.zip
> c96face22c569d5795ea549f729e2294
Checked that both contain the exact same files, which includes a
useless nearly empty
org.apache.sling.launchpad.app-5-incubator-sources.jar, no big deal.
The runnable jar found in those passes all launchpad/testing
integration tests, except those that use the launchpad/test-services
bundle which is not present, that's correct.
> The launchpad webapp:
> org.apache.sling.launchpad.webapp-5-incubator.war
> e5e7acb1d7140f10e8247a4076ca094c
Same test results as with the runnable jar, tested with tomcat 6.0.16.
> ...In addition I've built the corresponding maven artifacts of all modules...
Didn't check those.
Thanks for your work!
-Bertrand
-------------------------------------------------------------------------------
Test set: org.apache.sling.launchpad.webapp.integrationtest.JspForwardTest
-------------------------------------------------------------------------------
Tests run: 5, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 3.07 sec <<<
FAILURE!
testWithForward(org.apache.sling.launchpad.webapp.integrationtest.JspForwardTest)
Time elapsed: 0.342 sec <<< FAILURE!
junit.framework.AssertionFailedError: Text of node A is not included (<html>
<body>
<h1>JSP template</h1>
<p class="main">Text B 1241774350710</p>
<h2>Test 1</h2>
<p>pathToInclude =
/JspForwardTest/1241774350700/text_a_1241774350700</p>
<p>Including
/JspForwardTest/1241774350700/text_a_1241774350700</p>
<html>
<body>
<h1>JSP template</h1>
<p class="main">Text A 1241774350700</p>
<h2>Test 1</h2>
<h2>Test 2</h2>
<h2>Test 3</h2>
<h2>Test 4</h2>
</body>
</html>
<h2>Test 2</h2>
<h2>Test 3</h2>
<h2>Test 4</h2>
</body>
</html>
)
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at
org.apache.sling.launchpad.webapp.integrationtest.JspForwardTest.testWithForward(JspForwardTest.java:112)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:232)
at junit.framework.TestSuite.run(TestSuite.java:227)
at
org.junit.internal.runners.OldTestClassRunner.run(OldTestClassRunner.java:76)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
testWithForwardAndExtension(org.apache.sling.launchpad.webapp.integrationtest.JspForwardTest)
Time elapsed: 0.351 sec <<< FAILURE!
junit.framework.AssertionFailedError: Text of node A is not included (<html>
<body>
<h1>JSP template</h1>
<p class="main">Text B 1241774351054</p>
<h2>Test 1</h2>
<p>pathToInclude =
/JspForwardTest/1241774351043/text_a_1241774351043.html</p>
<p>Including
/JspForwardTest/1241774351043/text_a_1241774351043.html</p>
<html>
<body>
<h1>JSP template</h1>
<p class="main">Text A 1241774351043</p>
<h2>Test 1</h2>
<h2>Test 2</h2>
<h2>Test 3</h2>
<h2>Test 4</h2>
</body>
</html>
<h2>Test 2</h2>
<h2>Test 3</h2>
<h2>Test 4</h2>
</body>
</html>
)
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.assertTrue(Assert.java:20)
at
org.apache.sling.launchpad.webapp.integrationtest.JspForwardTest.testWithForwardAndExtension(JspForwardTest.java:119)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at junit.framework.TestCase.runTest(TestCase.java:168)
at junit.framework.TestCase.runBare(TestCase.java:134)
at junit.framework.TestResult$1.protect(TestResult.java:110)
at junit.framework.TestResult.runProtected(TestResult.java:128)
at junit.framework.TestResult.run(TestResult.java:113)
at junit.framework.TestCase.run(TestCase.java:124)
at junit.framework.TestSuite.runTest(TestSuite.java:232)
at junit.framework.TestSuite.run(TestSuite.java:227)
at
org.junit.internal.runners.OldTestClassRunner.run(OldTestClassRunner.java:76)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:62)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
at
org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at
org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
at
org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
