> Danny, > > > Hey Par, try this patch, it should also fix the issue with qos' of > > different case. Also catches the issue where the env var is set. > > This patch will be in 2.2.4. > > This also works. I actually wrote exactly this patch as my first > attempt, minus the QOS part. > > Another good thing with strcasecmp() is that it will still work if the > opposite problem happen and a upper-case account get into the system > somehow. Main reason I changed my mind and used xstrtolower() was to be > more consistent with slurmctld. Multiple calls to strcmp() should also > be slightly faster than strcasecmp() but probably nothing that will be > noticeable.
Yeah, I didn't think the minor speed deduction would be noticed with a client tool like this. > > What env var are you talking about? If you look at squeue/opts.c you will notice you can set up env vars if you only care about certain parameters all the time. In this case it is SQUEUE_ACCOUNT. At around line 322. There are quite a few others. I also fixed this issue for scancel. Danny > > /Pär > >
