We believe that removing that test will be fine, but it would take some work to be certain. Removing the test could break some QOS-related functionality.

Quoting Mike Schachter <[email protected]>:

I just posted a question yesterday about this, but might
be better on a separate thread for archival purposes.

I want to change the QOS of a job that is a RUNNING state,
but line 5882 of slurmctld/job_mgr.c (version 2.2.7) is preventing
me from doing so:

} else if (job_specs->qos) {
   slurmdb_qos_rec_t qos_rec;
   if (!IS_JOB_PENDING(job_ptr))              // i want to remove this
     error_code = ESLURM_DISABLED;
   else {

Is there any danger in removing that check, and allowing qos to
be changed for a running job?

  mike




Reply via email to