I have a bug report on displaying reservations when the 
"PrivateData=reservations" flag is set in slurm.conf.  Under this 
condition,  a normal user is prevented from displaying existing 
reservations,  but users "root", "SlurmUser",  and users designated as 
"AdminLevel=admin" or "AdminLevel=operator" should be able to display 
reservations with "scontrol show reservation". 

What actually happens when the flag is set  is that  root and Slurmuser 
can display all reservations, normal users receive 
"slurm_load_reservations error: Access/permission denied",     but users 
with AdminLevel admin or operator can only list reservations belonging to 
their own userid and get "No reservations in the system" if there are only 
reservations for other users.   I believe the intent is that AdminLevel 
users should be able to list all reservations.

I tracked this down to module "src/slurmctld/reservation.c"  where a call 
to "validate_slurm_user(uid)" should be a call to "validate_operator(uid)" 
in order to allow users with admin or operator status to list all 
reservations.   Along the way I found a couple of other minor problems: 1) 
"scontrol show config" and "sacctmgr show config" did not display the 
string "reservations" in the output for parameter "PrivateData", even 
though the flag was set,  and 2)  "scontrol reconfig" did not clear the 
"private_data" flag word before 'OR'ing in bits,  so that you could set 
additional bits with a reconfig,  but never turn off the bits that were 
already set, until slurmctld was stopped and restarted.

I've attached patch files for the above changes for both SLURM 2.3.1 and 
2.4.0pre2.

        -Don Albert-



Attachment: PrivateData_232.patch
Description: Binary data

Attachment: PrivateData_240.patch
Description: Binary data

Reply via email to