Thanks for the note about git-send-email. Up to this point I had never
heard of it. We try to preserve authorship as much as we can, but
sometimes it is labeled incorrectly.
A good example of how to do this when attaching a patch instead of
inline is from Matthieu Hautreux titled "Speed up of topology
information build in slurmd" sent on 01/25/12.
The attached patch contains all information needed by Git to preserve
authorship and such. I attached it again here only for reference.
Danny
On 02/22/12 10:22, Mark A. Grondona wrote:
On Wed, 22 Feb 2012 11:09:04 -0700, Danny Auble<[email protected]> wrote:
Currently it is an unknown problem that altered Par's patches the way it
did. It seems to happen at odd times. We were hoping the update we
just applied yesterday would of fixed the issue. But it seems it hasn't.
I know some like to see patches inline, but that is not the case for
me. I much prefer patches as attachments. If people choose not to use
the our bugzilla to submit patches attaching them to the email instead
of putting them inline would perhaps at least avoid the random
occurrence Par saw when sending his patches out.
The reason a lot of open source projects like patches to go inline
is that you can simply reply and make comments directly in the code.
(I'm not saying that is the only way to do it)
Since SLURM is hosted in git, it is also beneficial to send patches
inline using git-send-email(1), because then patches can be simply
applied with git-am (I notice you haven't been doing that, since
authorship of patches applied isn't being preserved in the SchedMD
git tree)
mark
Danny
On 02/22/12 08:59, Mark A. Grondona wrote:
On Wed, 22 Feb 2012 09:13:04 -0700, [email protected] (=?utf-8?Q?P=C3=A4r?=
Andersson) wrote:
Pär Andersson<[email protected]> writes:
I have found and fixed a few problems related to batch jobs with long
argument lists.
As the mailing list manager seem to mess up my patches I have sent a
pull request on Github instead.
https://github.com/SchedMD/slurm/pull/12
https://github.com/paran1/slurm/commits/argv-fixes
Nice work, thanks!
Moe, Danny, is there a fix for the mail list pending?
I really like to be able to see patches inline on the mail list.
(This facilitates commenting on patches where everyone can
see it)
Thanks,
mark
/Pär
From 350274d422d31979abb105b6b0e4bb113598a3ab Mon Sep 17 00:00:00 2001
From: Matthieu Hautreux <[email protected]>
Date: Wed, 25 Jan 2012 22:28:51 +0100
Subject: [PATCH 1/1] slurmd: build node hash table before the topology data
to speed up the process
---
src/slurmd/slurmd/slurmd.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/slurmd/slurmd/slurmd.c b/src/slurmd/slurmd/slurmd.c
index a17311d..298381c 100644
--- a/src/slurmd/slurmd/slurmd.c
+++ b/src/slurmd/slurmd/slurmd.c
@@ -1228,7 +1228,9 @@ _slurmd_init(void)
/*
* Get and set slurmd topology information
+ * Build node hash table first to speed up the topo build
*/
+ rehash_node();
slurm_topo_build_config();
_set_topo_info();
--
1.7.6.2
