Your point is well taken. This block of code will be removed from SLURM v2.5. We are only making bug fixes to v2.4 now.
Moe Quoting Alejandro Lucero Palau <[email protected]>: > > Hi, > > When a new reservation is created, the code tries first with current > idle nodes: > > /* First: Try to reserve nodes that are currently IDLE */ > if (bit_overlap(avail_bitmap, idle_node_bitmap) >= node_cnt) { > bit_and(avail_bitmap, idle_node_bitmap); > ret_bitmap = select_g_resv_test(avail_bitmap, node_cnt, > resv_desc_ptr->core_cnt, core_bitmap); > if (ret_bitmap) > goto fini; > } > > /* Second: Try to reserve nodes that are will be IDLE */ > > > I guess there's a reason for this behaviour: performance. However, I > think it should be always the second option. > > Creating a new reservation is not a usual task, so the best effort > should prevail versus performance at creation time. > > WARNING / LEGAL TEXT: This message is intended only for the use of the > individual or entity to which it is addressed and may contain > information which is privileged, confidential, proprietary, or exempt > from disclosure under applicable law. If you are not the intended > recipient or the person responsible for delivering the message to the > intended recipient, you are strictly prohibited from disclosing, > distributing, copying, or in any way using this message. If you have > received this communication in error, please notify the sender and > destroy and delete any copies you may have received. > > http://www.bsc.es/disclaimer >
