We prefer getting patches in an attached file form. This inline method will work though, but in the future adding the patch as an attachment is better. Using http://bugs.schedmd.com is even better since it is easier to keep track of there. It is easy to add a file to the bug and it won't get lost in the list.
We do not prefer GitHub Pull Requests and usually ask those submitting them to resubmit them in the fashion described above.
Thanks, Danny On 06/25/2014 05:16 AM, Rémi Palancher wrote:
From: Rémi Palancher <[email protected]> Hi developers, Here are 2 patches for 2 bugs I found while using `sacctmgr load`. I didn't find developers instructions nor your prefered way to receive patches. So These patches are formatted and directly sent by git to this mailing-list. If you prefer another way (GitHub PR?) please tell me! I'm looking forward to reading your comments on these patches. Rémi Palancher (2): Increased BUFFER_SIZE of sacctmgr load to 512KB Fix memory management on error in sacct load src/sacctmgr/file_functions.c | 18 ++---------------- src/sacctmgr/sacctmgr.c | 2 -- src/sacctmgr/sacctmgr.h | 2 +- 3 files changed, 3 insertions(+), 19 deletions(-)
