[slurm-dev] Configuration parsing issue with e.g. AccountingStoragePass

[Daniel Ahlin]

Hi,

I believe the parsing fallback for "old" configuration syntax of e.g.
AccountingStoragePass is wrong. It seems to me that if the "old"
syntax is found then NULL will always be returned. Below is a trivial
but untested patch for this:

--- slurm-14.11.2/src/plugins/auth/munge/auth_munge.c~  2014-12-12
20:21:29.000000000 +0100
+++ slurm-14.11.2/src/plugins/auth/munge/auth_munge.c   2014-12-19
08:12:16.348656780 +0100
@@ -709,7 +709,7 @@
        } else if (strchr(opts, '=')) {
                ;       /* New format, but socket not specified */
        } else {
-               socket = xstrdup(tmp);  /* Old format */
+               socket = xstrdup(opts); /* Old format */
        }

        return socket;

Regards,
Daniel Ahlin
PDC, KTH