On 1/9/16 1:30 , a b wrote: > (I would have preferred to open a bug report, but I do not know how or where > one does so for illumos-joyent, or whether it is even possible.)
You could open it up against github.com/joyent/illumos-joyent/issues. > When working in bldenv(1ONBLD), sitting in > smartos-live/projects/illumos/usr/src/ and doing an incremental build by > running just `dmake`, the above builds will fail because they do not > implement the "all" target. For what it's worth, that's an odd way to the incremental build. Doesn't mean we shouldn't fix it, but if you invoke a single target at the top-level, you'll generally want to do dmake install which ensures that the changes actually make it into the proto area. Though, most folks just use dmake inside of a subdirectory or two rather than at the top level and run nightly when they want to build everything. Again, no reason this shouldn't work, just figured you might want to understand the common workflow. > The attached patches should fix that. To prevent any misunderstandings, I > should note that my understanding of github is rudimentary, so if I need to > do a pull request, I kindly ask for guidance (assuming my patches are even > correct.) You don't have to create a pull request per se. The simplest thing is to provide patches or diffs on an issue like you did there. If it's a pull request, then it's certainly simpler to comment on. Alternatively, provide a webrev and we can discuss it. As far as correctness, the patches aren't quite right. They're replicating the 'target' target as the 'all' target. The 'all' target for illumos generally only ensures that the artifacts are built, it doensn't install them. Where as the 'install' target is what's responsible for putting it into the proto area. Robert ------------------------------------------- smartos-discuss Archives: https://www.listbox.com/member/archive/184463/=now RSS Feed: https://www.listbox.com/member/archive/rss/184463/25769125-55cfbc00 Modify Your Subscription: https://www.listbox.com/member/?member_id=25769125&id_secret=25769125-7688e9fb Powered by Listbox: http://www.listbox.com
