I've posted a webrev for those who prefer to review code that way:
http://www.shalman.org/webrev-118v2/
-Nahum
On 08/13/2014 04:32 PM, Nahum Shalman via smartos-discuss wrote:
I've always liked the joyent-minimal brand, but I've often wanted to
turn on services that weren't directly available in /lib/svc/manifest
in the minimal brand but were available in the regular joyent
brand[1]. At one point I even opened a pull request to add in the ones
I cared about at the time[2].
I believe I have implemented the general solution:
https://github.com/joyent/smartos-live/pull/339
My tests indicate that I've done things correctly, but extra eyeballs
would be appreciated, particularly if my changes to the README.smf
file could be improved.
Thanks!
-Nahum
[1] https://github.com/joyent/smartos-live/issues/118
[2] https://github.com/joyent/smartos-live/pull/212
P.S. I did take a pass at a general solution a year ago. It involved a
more ambitious merging of the joyent and joyent-minimal manifests
files. That method required much deeper changes and I got mired in
trying to find all the different corners that were affected. This
version is a much simpler change.
-------------------------------------------
smartos-discuss
Archives: https://www.listbox.com/member/archive/184463/=now
RSS Feed:
https://www.listbox.com/member/archive/rss/184463/22280019-340ab187
Modify Your Subscription:
https://www.listbox.com/member/?&;
Powered by Listbox: http://www.listbox.com
-------------------------------------------
smartos-discuss
Archives: https://www.listbox.com/member/archive/184463/=now
RSS Feed: https://www.listbox.com/member/archive/rss/184463/25769125-55cfbc00
Modify Your Subscription:
https://www.listbox.com/member/?member_id=25769125&id_secret=25769125-7688e9fb
Powered by Listbox: http://www.listbox.com
