Steve Peng writes:
>
> Many thanks to the comments from
>
> Dan Price
> Mike Shapiro
> Tom Whitten
> Liane Praza
>
> The incremental webrev which incorporate all the comments can be found
> under the same location. The original webrev has been renamed to
> 6351623-old for your reference. Again, send me any comment on those new
> changes.
>
> Thanks
>
> Steve
>
> Steve Peng wrote:
> > Please code review the following changes which address the service
> > import performance issue:
> >
> > 6351623 Initial manifest-import is slow
> >
> > It is under http://cr.opensolaris.org/~stevep/6351623
> >
> > The fix is to copy the repository to the fast tmpfs, import the
> > manifests and once the import is completed copy the repository
> > back to /etc/svc. During the verification cycle on both sparc
> > and amd64 systems, I see ~85 percent performance improvement.
> >
> > Any comment/suggestion is greatly appreciated.
> >
> > Thanks
> >
> > Steve
> >
> >
> > _______________________________________________
> > smf-discuss mailing list
> > smf-discuss at opensolaris.org
> >
>
> _______________________________________________
> smf-discuss mailing list
> smf-discuss at opensolaris.org
Just one comment.
usr/src/cmd/svc/configd/backend.c:
line 1142 - It might be useful to include the reason for the
error. I.e. the string returned by strerror(errno) should
be part of the error message. Same comment applies to
other cases where you call configd_critical() because of
the failure of a system call.
I don't need another webrev for this change. The other files look OK.
tom
