On Dec 3, 2008, at 5:40 AM, Renaud Manus wrote: > line 1957 - 1958 : unneeded since we aborting in bad_error() >
fixed. > line 2046 : 0 is fine but since it's a pointer, > NULL would be more appropriate. Unless anyone is of another opinion, I'm going to fix the convention used with sc_general to use NULL, and update the sc_enable as well. > > > -- Renaud > > Sean Wilcox wrote: >> Webrev updated with new fix. >> http://cr.opensolaris.org/~swilcox/6765907/ >> Bug -id : http://bugs.opensolaris.org/view_bug.do?bug_id=6765907 >> services can be started without a running snapshot >> Sean Wilcox wrote: >>> Tom's got a good point here, even using >>> uu_list_insert_before(list, uu_list_first(list), "enabled >>> element") I have no guarantee that this element will stay the >>> first element, and that I can keep other things from dumping in >>> front of it on the list. >>> >>> So back to the drawing board, with a shot a Tom's idea here... >>> I'll repost the webrev when complete. >>> >>> >>> >>> > Sean Wilcox x79711 303.272.9711
