* Mark Martin <storycrafter at gmail.com> [2007-10-11 15:42]: > On 10/10/07, Stephen Hahn <sch at sun.com> wrote: > > > > * Mark Martin <storycrafter at gmail.com> [2007-10-10 17:59]: > > > I would appreciate review comments for my fix for bug id 6504438 found > > at > > > http://cr.opensolaris.org/~devnull/6504438/ > > > > > > Bug ID link: > > > http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6504438 > > > > I was looking at log_instance() calls in the neighborhood. > > log_instance() takes responsibility for printing '\n', so I would > > suggest correcting line 700 as well. > > > > (Nits.) Use of final '.' has been inconsistent. I think we've been > > consistent about using \' as the embedded delimiter in the messages. > > (I would probably drop the "the" and "a", but that's just me.) > > New diff here: > http://cr.opensolaris.org/~devnull/6504438-revised/ > > I expanded scope a touch and (I believe) cleaned up all suspects in startd/ > per your nits. I opted to include the final "." because: > > 1) It was present in the majority of other log_instance calls. > 2) It was often used. In the middle. Of some log_instance calls.
The new webrev looks fine to me; nice. +1 - Stephen
