On Tue 16 Oct 2007 at 12:56PM, Antonello Cruz wrote:
> The changes look good to me.
Looks OK to me too (although this isn't really my area of expertise).
Make sure to update the SCCS comment so the bugid appears, for some
reason it seems to be missing.
It might be nice to reference the relevant specification which allows
"."s in service names. The new comment is slightly confusing in that
it says: "Service names" which could either mean /etc/services services
names, or SMF service names.
Maybe something like...
SMF service names may not contain '.', but IANA services
do allow its use, and property names can contain '.' as returned
by propertyname(). So if the resultant SMF service name
would contain a '.' we fix it here.
It would also be nice if 'servicename()' has a comment about what
it does, but you don't have to fix that.
BTW If you need webrev to create links to bugs.opensolaris.org, use the -O
option.
-dp
> Antonello
>
> Tony Nguyen wrote:
> > Hi all,
> >
> > I'm sponsoring this fix for Ceri Davies(OS0135). The bug is
> >
> > 6611124 inetconv may create manifests that svccfg cannot import
> >
> > Webrev and bug pointers:
> > http://cr.opensolaris.org/~tonyn/6611124/
> > http://bugs.opensolaris.org/view_bug.do?bug_id=6611124
> >
> > Michael, your name was given as someone with much knowledge in inetd.
> > It's not an extensive change, but would you mind take a look?
> >
> > Thanks,
> > tony
> > _______________________________________________
> > smf-discuss mailing list
> > smf-discuss at opensolaris.org
> _______________________________________________
> smf-discuss mailing list
> smf-discuss at opensolaris.org
--
Daniel Price - Solaris Kernel Engineering - dp at eng.sun.com - blogs.sun.com/dp
