Eric Schrock wrote: > I'm looking for someone to review the changes for: > > 6608098 startd's fsminimal filesystem checks could be a little more explicit > > Webrev at: > > http://cr.opensolaris.org/~eschrock/startd/ > > You can ignore everything but the 'specials.c' changes.
l112: You could move the fs_is_read_only() call here into the conditional at l118. I'm torn on whether it's more or less clear, so feel free to keep it. Other than that, this looks OK. I believe you'll be saved from a "/var remount failed" message on the miniroot due to the rfsid != fsid check, but testing will confirm. > I've tested > this on stock Solaris systems as well as a system with a read-only root > but writable /etc/svc. I'd also like to test operation under the > standard Solaris miniroot, but I have no idea how to build or test this > environment - does anyone have info on how to do this? Mercifully, I don't remember. Sorry. liane
