Webrev is updated : http://cr.opensolaris.org/~swilcox/full_webrev.3/
Added a error message to the protocol.c call to make sure it's noted. Reworked the librestart.c function. Liane Praza wrote: > Sean Wilcox wrote: >> Webrev has been updated to include recent comments. As well, a new >> copy of the flag day has been attached. >> >> http://cr.opensolaris.org/~swilcox/full_webrev.2/ > > Renaud's comment about the max channel name is valid. > > graph.c l2033, protocol.c l332: If we ever called > restarter_protocol_init_delegate() with startd as an argument, we'd > fall into the error case. If that shouldn't happen (and clearly it > must not, or your updated startd wouldn't work at all), should > assert() that the fmri isn't startd in one of these two places. I go > back and forth about which one. > > Thanks for getting rid of all the uu_dies() in protocol.c! > > librestart.c l158, I think you're missing a return (NULL). > > liane > _______________________________________________ > smf-discuss mailing list > smf-discuss at opensolaris.org > > -- Sean Wilcox 303.272.9711 x79711
