Quoth Sean Wilcox on Fri, Apr 17, 2009 at 02:13:21PM -0600:
> Webrev updated :
>
> http://cr.opensolaris.org/~swilcox/webrev.3
lib/librestart/common/librestart.c
2106,17,27,42,55: Please add the profile name.
2196: Can we include the pg name?
2196,2201: Please change "user" to "\"%s\"" and add SCF_PROPERTY_USER.
2212,2220: Please change "group" to \"%s\"" and add
SCF_PROPERTY_GROUP.
2232: Isn't ci->uid a uid_t? lint should catch this if you add
"/* PRINTFLIKEn */" before mc_error_create()'s definition.
2242: Shouldn't you include r in the message?
2256,67: Please add \"%s\" and SCF_PROPERTY_SUPP_GROUPS to this
message. I'm not sure whether it's better to add it in parentheses
after "supplemental groups", or whether it should replace that
phrase. Choose one.
2272: Please improve the diction of this message, as with "... values
in \"%s"", or "... in value \"%s\"".
2289,2305: Please change "privileges" to "\"%s\"" and add
SCF_PROPERTY_PRIVILEGES.
2474: I think this would be more useful as "Invalid client version %d.
(Expected %d)", or similar.
2529: This message seems pretty bare. Can you add some text which
indicates what was attempted?
2558: Please file a bug to improve this error message after you
integrate.
2586: Please change this to indicate that the property group could not
be found. (If the property were deleted, scf_pg_get_property()
would just return SCF_ERROR_NOT_FOUND. And to the client, the pg
being deleted is the same as it not existing in the first place.)
And when this integrates, file a bug to investigate making this
function fall back to instpg if pg == methpg.
2606: Please change this to indicate that the property group could not
be found. (We guarantee the contents of property groups don't
change once you have a reference, and as above, we shouldn't
differentiate between deleted and not-found.)
2621: Can we include the property group name?
2716,2820: Please change this to indicate that the property group
could not be found.
2883: Why do you include cip->uid?
2902: cip->vbuf is a string. And please rearrange this message to
something like "Project ID \"%s\" is too big.".
2907: cip->vbuf is unused.
2912: If this should be the same message as ERANGE, please consolidate
the cases.
2971: Please change this to indicate that the property group could not
be found.
David
