Antonello Cruz writes:
> Please review the code for RFE: 5079353 "Contract 'decoration' with
> service FMRI"
>
> webrev: http://cr.opensolaris.org/~acruz/5079353/
> workspace: /net/coupe.sfbay/builds/acruz/fmri/
> RFE: http://monaco.sfbay.sun.com/detail.jsf?cr=5079353
>
>
> Thanks,
>
> Antonello
> _______________________________________________
> smf-discuss mailing list
> smf-discuss at opensolaris.org
Good job Antonello. 766 lines of changes and I only found two minor things
to complain about.
tom
usr/src/cmd/svc/lsvcrun/lsvcrun.c:
501 It would probably be a good idea to malloc() this large
buffer rather than putting it on the stack. If you
malloc() you can handle the failure gracefully. If there
is not enough memory to put it on the stack, the process
aborts with SEGV. This is a trick that I learned from
David.
usr/src/cmd/init/init.c:
699 Why was the copyright set back to 2007 rather than 2008?
