Alan,

I took a look at the 3 files that you suggested below, and I have only one
small comment on open-src/lib/fontconfig/fc-cache.sh.
        line 40:
                Since "start" is the only valid method, would it make sense
                to replace <method> with start?

As far as I can tell, the rest looks good in these files

tom

Alan Coopersmith writes:
> I've posted a webrev for the changes to implement the force_rebuild
> property in the fc-cache SMF service in the X Consolidation at:
> 
>       http://cr.opensolaris.org/~alanc/fc-cache-force-rebuild/
> 
> It also cleans up the existing packaging postremove scripts to share
> code instead of having three copies of the same complex bits that have
> to be updated every time a new twist on install comes around.
> 
> For the people on the SMF alias I've cc'ed, the SMF relevant bits are:
> 
> - open-src/lib/fontconfig/fc-cache.sh
> 
>    The new service method script, checks for the property, and if set
>    adds the -f flag to the fc-cache call and then clears it for the next
>    run.
> 
> - open-src/lib/fontconfig/fc-cache.xml
> 
>    The service manifest, changed to use the method script instead of
>    calling fc-cache binary directly.
> 
> - packages/common_files/proc.fc_rebuild
> 
>    The snippet inserted into the postinstall & postremove scripts in the
>    font packages to set the force_rebuild property to true when the
>    package is added or removed.
> 
> Thanks to anyone who has time to look at this.
> 
> -- 
>       -Alan Coopersmith-           alan.coopersmith at sun.com
>        Sun Microsystems, Inc. - X Window System Engineering
> 
> _______________________________________________
> smf-discuss mailing list
> smf-discuss at opensolaris.org

Reply via email to