The fix doesn't seem complete to me.
You cannot just return scf_error() because fmri_to_entity()
is only supposed to return:
SCF_ERROR_NO_MEMORY
SCF_ERROR_INVALID_ARGUMENT
SCF_ERROR_CONSTRAINT_VIOLATED
SCF_ERROR_NOT_FOUND
SCF_ERROR_NONE
If you want to do that then you must also change the comments
and verify the callers handle the new return values correctly.
Btw, you could simplify the fix to
if (scf_handle_decode_fmri(h, fmri, NULL, svc, NULL, NULL, NULL,
SCF_DECODE_FMRI_EXACT) != SCF_SUCCESS)
return (scf_error());
-- Renaud
Steve Peng wrote:
> Hi all,
>
> I am sponsoring the fix contributed by Arjun Nair for the following bug:
>
> 6297026 fmri_to_entity() should have finer error semantics
>
> The fix is short (only three lines) and straightforward. Please review
> it and send me any feedback. Changes can be found under
>
> http://cr.opensolaris.org/~stevep/6297026
>
> Thanks
>
> Steve
> _______________________________________________
> smf-discuss mailing list
> smf-discuss at opensolaris.org
