hi folks this is a request for reviewers for the ON component of the quagga OpenSolaris project (cross-posting to smf-discuss as there is a significant SMF component to these changes). we'd like to set a timer of 23 October for the review. the webrev of the code is located here:
http://cr.grommit.com/~amaguire/quagga/webrev the internal webrev is here http://whitestar1-4.east/quagga/webrev/ (it contains one additional Makefile under the "closed" source tree.) the changes consist of an update to routeadm (1M) to support interaction with SMF routing daemon services, service conversions for in.routed, in.ripngd, in.ndpd, and in.rdisc, factoring out of routing-related configuration from svc:/network/initial to svc:/network/routing-setup, and a general Makefile simplification for SMF manifests/method targets. this code differs from that previously reviewed (http://www.opensolaris.org/jive/thread.jspa?threadID=9197&tstart=135) in the following ways: - routeadm (1M) has been updated to utilize temporary SMF state changes to implement the "make configuration changes for application on reboot" semantics it supports. this saves having to issue a "routeadm -u" on every boot. see comments in routeadm.c for details. - global routing services svc:/network/routing/ipv4-routing and svc:/network/routing/ipv6-routing, and dependencies on them, have been removed. instead, ipv4-routing is reported as enabled now if any ipv4-routing daemon is enabled, ditto for ipv6. - routing services break daemon commandline arguments up into properties, in line with the SMF ARC policy. subfunctions in usr/src/cmd/svc/shell/routing_include.sh are provided to simplify this process (which is carried out in the start method of routing daemon services) - instead of supplying -e/-d operations for directly enabling/disabling routing daemons, routeadm supports setting a list of daemon services, which will then be enabled when v4/v6 routing is (as appropriate to daemon type). for example, running # routeadm -s routing-svcs="route:default ripng:default" marks those services "to be enabled" if ipv4/ipv6 routing is enabled. - "routeadm -p" supports an option parameter specifying single option/variable to be displayed in parseable format (rather than all options/properties). the updated Quagga design document http://www.opensolaris.org/os/project/quagga/quagga-design.pdf provides more background. there are no changes since the last review to files touched to fix "6440342 remove redundancies in smf-related makefiles by moving manifest rules to usr/src/cmd/Makefile.targ", other than merging with the more recent versions of those Makefiles. as always, participation is both greatly appreciated and needed, and if any supplemental information is required, don't hesitate to ask! thanks very much! alan This message posted from opensolaris.org
