Tom Whitten wrote: > Tony Nguyen writes: >> Liane Praza wrote: >>> Tony Nguyen wrote: >>>> I'd appreciate a review for >>>> >>>> 6834760 >>>> <http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6834760> >>>> svcadm shouldn't assert() when not enough privileges >>>> >>>> which has been an annoyance for folks. >>>> >>>> Webrev: >>>> http://cr.opensolaris.org/~tonyn/6834760/ >>> I think the changes to configd are fine, but shouldn't there be >>> changes to svcadm too? I can't recall which scfdie() we actually hit, >>> but if the user doesn't have privs, we still shouldn't assert(), we >>> should give an appropriate permission error. >>> >> Right. I was using a different test case to reproduce the bug so >> completely forgot about the svcadm piece. Thanks for catching this. The >> additional change to svcadm.c is tested and included in the updated webrev: >> >> http://cr.opensolaris.org/~tonyn/6834760/ >> >> Thanks, >> -tn >> _______________________________________________ >> smf-discuss mailing list >> smf-discuss at opensolaris.org > > Just one comment. The rest looks good. > > usr/src/cmd/svc/svcadm/svcadm.c: > line 530: I'm wondering why the EROFS case should not also go > to out. Does it make any sense to call > set_astring_prop if we cannot write to the file > system? >
Good point. I'll make that change. Thanks Tom. -tn
