Sean Wilcox writes:
> This is really a re-review of the same code that was reviewed a number 
> of months ago, but got back-burnered as the test development spun out of 
> control, and other things took precedence.  I have now fixed the bug in 
> the test suite (which is under
> second round of reviews now) and would just like to get a fresh review 
> of this code.
> 
> I believe Liane and Dave Bustos looked at this originally...
> 
> http://cr.opensolaris.org/~swilcox/6311392_webrev.0/

Don't forget to update the copyrights to 2010.

usr/src/cmd/svc/startd/libscf.c:
        It seems as if the only change in this file is to #include
        stings.h.  Presumably, has compiled in the past.  Why was it
        necessary to add the #include.

The rest looks good.  Thanks for fixing these bugs.

tom

Reply via email to