I noticed that PDUs parsed by this method have an incorrect address type. 
 The address type is set twice:

pdu.setAddressType(addressType);            <<< set correctly here to the 
value read from the PDU
pdu.setAddress(destinationAddress);          <<< set incorrectly as a 
side-effect in this method

pdu.setAddress internally invokes addressType.  It depends on the presence 
of a leading "+" character to determine that a number is internationally 
formatted rather than depending on the value read from the message.  I 
don't believe that is correct.

Quick and dirty fix is to swap the above two lines.  Any thoughts?

-- 
You received this message because you are subscribed to the Google Groups 
"SMSLib Discussion Group" group.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/smslib/74629b14-761d-4ba5-8f74-49a17dfc0111%40googlegroups.com.

Reply via email to