Chris Eidhof <[email protected]> writes: > Hey all, > > Again, congratulations on the release. Everything looks quite awesome: > the documentation, the design, the tests and benchmarks. > > I have two comments on the design of the URL matching: > > Consider matching the "echo/:s" URL. It puts a key "s" with the > corresponding values in rqParams. Why did you make this choice? Have > you considered putting it in a different data structure? I can see why > it's useful, but is it possible this way to accidentally overwrite > POST-data? This solution feels too much like PHP's $_REQUEST.
Yes we need a way to disambiguate whether a variable came from the query string, post body, or url; this is on the todo list. Originally (loooong time ago) I was doing it this way but scrapped it because one map is simpler. G -- Gregory Collins <[email protected]> _______________________________________________ Snap mailing list [email protected] http://mailman-mail5.webfaction.com/listinfo/snap
