Just a couple of things, really: - httpServe needed fixing for changes in ListenHttp/ListenHttps. - completeConfig wouldn't add a default listener in case one was missing
I don't think any of these are going to cause problems with Enumerator. I've been having problems getting Hint to work, though. Ozgun On 12/4/10 8:35 PM, "Gregory Collins" <[email protected]> wrote: >BTW I haven't heard from duairc in a while so I'm planning on merging >a bunch of the snap-extensions stuff into snap proper myself, probably >tomorrow. > >Ozgun: what's changed between your fork of snap-extensions and >duairc's? I've already made some changes to sync it with Snap's >enumerator branch, is there anything there beyond that? > >(I suppose I could just read the diff myself, I'm getting lazy) > >G > >On Sat, Dec 4, 2010 at 7:13 PM, Ozgun Ataman <[email protected]> wrote: >> I actually have a fork of snap-extensions that works with latest >>changes to >> Snap. I have not tested thoroughly, but simple applications seem to work >> fine. >> https://github.com/ozataman/snap-extensions >> Hope this helps. >> Ozgun >> >> Date: Fri, 3 Dec 2010 13:35:59 -0500 >> From: MightyByte <[email protected]> >> Subject: Re: [Snap Framework] basic questions with snap >> To: Daniel Lyons <[email protected]> >> Cc: [email protected] >> Message-ID: >> <[email protected]> >> Content-Type: text/plain; charset=ISO-8859-1 >> On Fri, Dec 3, 2010 at 1:08 PM, Daniel Lyons <[email protected]> >>wrote: >> >> This looks much cleaner than I was expecting for the amount of >> effort. I am glad I asked! Are you planning on integrating >> snap-extensions into Snap later on? >> >> Yes, it will be in before we release 0.3. >> >> I'm currently having trouble building snap-extensions, by the way: >> ? ?[11 of 12] Compiling Snap.Extension.Server ( >> ? ?src/Snap/Extension/Server.hs, dist/build/Snap/Extension/Server.o ) >> ? ?src/Snap/Extension/Server.hs:135:26: Not in scope: `getAddress' >> ? ?src/Snap/Extension/Server.hs:136:26: Not in scope: `getPort' >> ? ?cabal: Error: some packages failed to install: >> ? ?snap-extensions-0.1 failed during the building phase. The exception >>was: >> ? ?ExitFailure 1 >> >> It looks like snap-extensions hasn't been kept in sync with more >> recent changes to Snap. I think that code is getting the IP address >> and port that the server is listening on. If you look at the Config >> and ConfigListen data types defined at >> >>https://github.com/snapframework/snap-server/blob/master/src/Snap/Http/Se >>rver/Config.hs#L67 >> you'll see that this probably needs to be changed to get the data from >> Config's listen field. It might help to look at the commit history >> for this file to see how things changed in the past. I don't have >> time to fix this right now. Hopefully it points you in the right >> direction so you can fix it yourself. It should be a fairly >> straightforward change. >> >> _______________________________________________ >> Snap mailing list >> [email protected] >> http://mailman-mail5.webfaction.com/listinfo/snap >> >> > > > >-- >Gregory Collins <[email protected]> _______________________________________________ Snap mailing list [email protected] http://mailman-mail5.webfaction.com/listinfo/snap
