Looks good to me too. Consuming the semicolon shouldn't be necessary, since this is just speculatively passing to decide whether to escape the ampersand.
On Wed, Jan 30, 2019, 11:23 AM MightyByte <mightyb...@gmail.com> wrote: > Yes, a pull request would be great. That will trigger our CI and make > sure your change passes the tests. At first glance it seems like we might > still need to consume the semicolon. The test suite should catch that > though. > > Sent via Superhuman <https://sprh.mn/?vip=mightyb...@gmail.com> > > > On Wed, Jan 30, 2019 at 10:34 AM, Pedro Vasconcelos < > pvasconcelo...@gmail.com> wrote: > >> domingo, 27 de Janeiro de 2019 às 03:00:24 UTC, mightybyte escreveu: >>> >>> It seems like we could just change our definition of "looks like an >>> entity" to not require the semicolon. If any valid entity is a prefix of >>> the characters following the ampersand, then we would consider it >>> ambiguous. Do you think that would solve your problem? I don't see any >>> problem with this because it would still conform to the spec. >>> >>> I would accept a pull request implementing this. >>> >> >> I'd done the change and it solves the issue; instead of requiring the >> trailing semicolon, any name following an & gets escaped: >> >> >> https://github.com/pbv/xmlhtml/commit/163e6fbc33138ffb7c32330828f068099f651572 >> >> Do you want me to send you a pull request? >> >> -- >> >> --- >> You received this message because you are subscribed to the Google Groups >> "Snap Framework" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to snap_framework+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > > --- > You received this message because you are subscribed to the Google Groups > "Snap Framework" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to snap_framework+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- --- You received this message because you are subscribed to the Google Groups "Snap Framework" group. To unsubscribe from this group and stop receiving emails from it, send an email to snap_framework+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
