Hello Sjoerd,

Issue 1 is OK, in the code "pdu" *is* the ScopedPDU!
I have fixed issue 2, it is indeed the wrong stats
counter. The fix will be in the next release.

Best regards,
Frank

Sjoerd van Doorn wrote:
Also 2 review comments:
1:
 Can someone explain to me why on line 656 of MPv3.java:
 {snip}
// get length of scoped PDU int scopedPDULength = pdu.getBERLength(); BEROutputStream scopedPdu = new BEROutputStream(ByteBuffer.allocate(scopedPDULength)); {/snip} takes the length of the PDU instead of the scoped PDU ? 2: On line 709 of USM.java I think the wrong constant is being counted (e.g. statsNotInTime i.s.o. statsUnknownEngineId) Thanks in advance and hopefully someone can help me. Regards, Sjoerd


_______________________________________________
SNMP4J mailing list
[email protected]
http://lists.agentpp.org/mailman/listinfo/snmp4j

--
AGENT++
http://www.agentpp.com
http://www.mibexplorer.com
http://www.mibdesigner.com

_______________________________________________
SNMP4J mailing list
[email protected]
http://lists.agentpp.org/mailman/listinfo/snmp4j

Reply via email to