duftler 02/05/02 11:02:51
Modified: java/src/org/apache/soap/server ServiceManager.java
Log:
A type-check was not being performed due to its placement. It has been
moved so that it now has effect. For more info, see:
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=2668
Submitted by: [EMAIL PROTECTED]
Reviewed by: Matthew J. Duftler ([EMAIL PROTECTED])
Revision Changes Path
1.17 +6 -3 xml-soap/java/src/org/apache/soap/server/ServiceManager.java
Index: ServiceManager.java
===================================================================
RCS file: /home/cvs/xml-soap/java/src/org/apache/soap/server/ServiceManager.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- ServiceManager.java 28 Jun 2001 20:08:47 -0000 1.16
+++ ServiceManager.java 2 May 2002 18:02:51 -0000 1.17
@@ -175,10 +175,13 @@
else
c = Class.forName( className, true, cl );
+ if (!ConfigManager.class.isAssignableFrom(c)) {
+ throw new IllegalArgumentException("Class '" + className +
+ "' isn't a ConfigManager.");
+ }
+
configMgr = (ConfigManager) c.newInstance();
- if ( !(configMgr instanceof ConfigManager) )
- throw new Exception( "Class " + className + " isn't a " +
- "ConfigManager" );
+
// Set the servlet context.
configMgr.setContext(context);
// Now check for options
