Folks, FYI, I have closed this PR (see my justification in the comment at GH). In case you feel we should consider it as it is, feel free to reopen.
Mat ---------- Forwarded message ---------- From: ArnaudD-FR <notificati...@github.com> Date: 31 July 2013 20:15 Subject: [soci] Replace type_ptr by shared_ptr and solve some issues (#184) To: SOCI/soci <s...@noreply.github.com> Replace type_ptr by shared_ptr that can be easily replaced by boost::shared_ptr Solve some issues encountered using sqlite3 backend Not tested with any other backend ________________________________ You can merge this Pull Request by running git pull https://github.com/ArnaudD-FR/soci develop Or view, comment on, or merge it at: https://github.com/SOCI/soci/pull/184 Commit Summary Create sqlite3 backend errors to get error details Replace use and into ptr type by a shared ptr Add base_type for each exchange_traits overload conversion_use_type::ownInd_ was not initialized Minor fix, in use_type last constructor, const was set to false instead of true values containers are using shared_ptr to encapsulate dynamic allocated memory File Changes A src/backends/sqlite3/error.h (24) M src/backends/sqlite3/session.cpp (13) M src/backends/sqlite3/soci-sqlite3.h (3) M src/backends/sqlite3/standard-into-type.cpp (7) M src/backends/sqlite3/statement.cpp (11) M src/core/exchange-traits.h (24) M src/core/into-type.h (4) M src/core/ref-counted-prepare-info.cpp (21) M src/core/ref-counted-prepare-info.h (4) M src/core/row.h (4) A src/core/shared_ptr.h (79) M src/core/statement.cpp (45) M src/core/statement.h (10) M src/core/type-conversion.h (2) M src/core/use-type.h (6) M src/core/values.h (29) Patch Links: https://github.com/SOCI/soci/pull/184.patch https://github.com/SOCI/soci/pull/184.diff -- Mateusz Loskot, http://mateusz.loskot.net "Participation in this whole process is a form of torture" ~~ Szalony, wspinanie.pl ------------------------------------------------------------------------------ Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk _______________________________________________ soci-devel mailing list soci-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/soci-devel
