Hello, I've finally got around to getting our projects to build with the develop SOCI branch which uses the new headers organization. I didn't have any particular problems, but I did notice a couple of things which, I think, it might make sense to change:
1. The old <soci.h> now has to be included as <soci/soci.h> which seems a bit redundant to me. I totally agree that it makes sense to put the other headers under soci directory, but perhaps it would be better to leave soci.h itself outside of it? It's not a huge change one way or the other, of course, but I think it would encourage people to update their projects more correctly as currently there is a temptation to add soci/include/soci directory to the include paths and avoid modifying the code using "#include <soci.h>" at all, while if the header were moved one level up, people could add soci/include itself to the compiler headers search path, avoid modifying the code including soci.h but use soci/foo.h for everything else. 2. The new soci/firebird/soci-firebird.h header path is clearly redundant. I mean, I understand that either soci or firebird part could need to be repeated, but is it really necessary to repeat both? Of course, if you think it's important to keep the same names for backwards compatibility, this would be a good enough reason, but if we consider that relatively few users include these backend-specific headers, perhaps we could use some shorter names for them? To be consistent with my suggestion above, we could use just soci/firebird.h (and put any additional files specific to this backend in soci/firebird subdirectory). What do you think? VZ
pgpDzb9Luv6gZ.pgp
Description: PGP signature
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech
_______________________________________________ soci-devel mailing list soci-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/soci-devel
