On 10 September 2017 at 21:30, Vadim Zeitlin <vz-s...@zeitlins.org> wrote: > On Sun, 10 Sep 2017 20:04:55 +0200 Mateusz Loskot <mate...@loskot.net> wrote: > > ML> I wonder if there is need to take care of EOLs. > ML> I'm quite certain, most if not all of us who develop/build SOCI on Windows > ML> follow the Git/GitHub guidelines for dealing with EOLs > ML> https://help.github.com/articles/dealing-with-line-endings/ > ML> > ML> git config --global core.autocrlf true > ML> > ML> and let Git on Windows to autoconvert to CRLF. > > FWIW I've never done this and strongly recommend against doing it because > nowadays almost all tools are finally capable of dealing with Unix EOLs > even under Windows and there is rarely any reason to use DOS EOLs, except > for Windows-specific files such as .vcxproj/.sln/.bat.
Although I agree, I speak from position of general public who, I bet, in majority follows recommendations from Git documentation and GitHub too. > ML> So, perhaps we should also specify EOL for source code and other files > ML> with .gitattributes and keep it in sync with .editorconfig > ML> > ML> Thoughts? > > I don't know how does EditorConfig work with core.autocrlf==true, if this > helps it in this case without breaking anything else -- why not. EditorConfig takes care of EOLs when a file is being edited/saved. .gitattributes takes care of EOLs of files when they are added to git index, etc. > But please let's avoid forcing everybody to use CR LFs under Windows. No such thing was/is being suggested. > ML> Despite which reformat we agree upon, either whitespaces for > .editorconfig only > ML> or the complete using clang-format (which would include the > ML> .editorconfig one of course), > ML> I'd vote for one big reformat with single commit. > ML> > ML> Thoughts? > > Yes, a single commit would be definitely preferable. Good. Best regards, -- Mateusz Loskot, http://mateusz.loskot.net ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ soci-devel mailing list soci-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/soci-devel
