Eric, Eric Dumazet schrieb: > Sebastian Haas a écrit : >> This patch adds support for one channel CAN/USB interace CPC-USB/ARM7 from >> EMS Dr. Thomas Wuensche (http://www.ems-wuensche.com). >> >> Signed-off-by: Sebastian Haas <[email protected]> >> --- >> > > ... > >> + netif_rx(skb); >> + >> + dev->netdev->last_rx = jiffies; > > Please dont update last_rx unless your driver *really* needs to. > > drivers/net/sky2.c is an example of driver that has to update ->last_rx > for its internal use. Okay, I see. Removed, thanks.
Cheers, Sebastian Haas -- EMS Dr. Thomas Wuensche e.K. Sonnenhang 3 85304 Ilmmuenster HRA Neuburg a.d. Donau, HR-Nr. 70.106 Phone: +49-8441-490260 Fax : +49-8441-81860 http://www.ems-wuensche.com _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
