Hello Wolfgang,

I have tested the latest SVN version (r1060) and the order of frame 
problem is gone (tested also with IXXAT proprietary test environment). 

However, if setting the CAN_MSG_COUNT to bigger that 12 in the
canecho_gen.c , the messages are lost on the MSCAN DUT.

Attached is the trace with CAN_MSG_COUNT equal to 20. Message #55
is wrong here, two CAN messages with ID 77 are lost on reception.

Regards,
Vladislav

-----Original Message-----
From: Wolfgang Grandegger [mailto:[email protected]] 
Sent: Wednesday, September 16, 2009 10:45 AM
To: [email protected]
Cc: Gribov, Vladislav
Subject: Re: [PATCH] mscan: fix TX message handling to ensure proper
message ordering

Wolfgang Grandegger wrote:
> can: mscan: fix TX message handling to ensure proper message ordering
> 
> An out-of-order TX message problem has been reported and demonstrated
> by Vladislav. The TX message buffers were not handled properly if
> just one message was pending. This patch remembers the id of the
buffer
> used previously and increase the buffer priority if the next one has a
> lower id number. This allows up to approx. 3*256 messages to be sent
> until the lowest buffer priority of 255 is reached. There is still
> room for improvements using a more tricky method.
> 
> Signed-off-by: Wolfgang Grandegger <[email protected]>

Applied to SVN trunk. Vladislav, it would be nice if you could validate
the fix on your setup when time permits. It worked fine on mine.

Wolfgang.
"Bus";"No";"Time (abs)";"State";"ID (hex)";"Length";"Message";"Data 
(hex)";"ASCII"
"CAN";"1";"00:18:38.307.592.0";"     ";"77";"8";"";"00 01 02 03 04 05 06 
07";"........"
"CAN";"2";"00:18:38.308.683.7";"     ";"78";"8";"";"01 02 03 04 05 06 07 
08";"........"
"CAN";"3";"00:18:38.310.554.5";"     ";"77";"8";"";"01 02 03 04 05 06 07 
08";"........"
"CAN";"4";"00:18:38.311.607.1";"     ";"78";"8";"";"02 03 04 05 06 07 08 
09";"........"
"CAN";"5";"00:18:38.312.558.4";"     ";"77";"8";"";"02 03 04 05 06 07 08 
09";"........"
"CAN";"6";"00:18:38.313.501.8";"     ";"77";"8";"";"03 04 05 06 07 08 09 
0A";"........"
"CAN";"7";"00:18:38.314.452.2";"     ";"77";"8";"";"04 05 06 07 08 09 0A 
0B";"........"
"CAN";"8";"00:18:38.315.385.8";"     ";"77";"8";"";"05 06 07 08 09 0A 0B 
0C";"........"
"CAN";"9";"00:18:38.316.328.3";"     ";"77";"8";"";"06 07 08 09 0A 0B 0C 
0D";"........"
"CAN";"10";"00:18:38.317.254.8";"     ";"77";"8";"";"07 08 09 0A 0B 0C 0D 
0E";"........"
"CAN";"11";"00:18:38.318.197.2";"     ";"77";"8";"";"08 09 0A 0B 0C 0D 0E 
0F";"........"
"CAN";"12";"00:18:38.319.139.7";"     ";"77";"8";"";"09 0A 0B 0C 0D 0E 0F 
10";"........"
"CAN";"13";"00:18:38.320.082.2";"     ";"77";"8";"";"0A 0B 0C 0D 0E 0F 10 
11";"........"
"CAN";"14";"00:18:38.321.039.7";"     ";"78";"8";"";"03 04 05 06 07 08 09 
0A";"........"
"CAN";"15";"00:18:38.321.974.2";"     ";"77";"8";"";"0B 0C 0D 0E 0F 10 11 
12";"........"
"CAN";"16";"00:18:38.322.916.7";"     ";"77";"8";"";"0C 0D 0E 0F 10 11 12 
13";"........"
"CAN";"17";"00:18:38.323.843.1";"     ";"77";"8";"";"0D 0E 0F 10 11 12 13 
14";"........"
"CAN";"18";"00:18:38.324.792.7";"     ";"77";"8";"";"0E 0F 10 11 12 13 14 
15";"........"
"CAN";"19";"00:18:38.325.719.2";"     ";"77";"8";"";"0F 10 11 12 13 14 15 
16";"........"
"CAN";"20";"00:18:38.326.645.7";"     ";"77";"8";"";"10 11 12 13 14 15 16 
17";"........"
"CAN";"21";"00:18:38.327.556.2";"     ";"77";"8";"";"11 12 13 14 15 16 17 
18";"........"
"CAN";"22";"00:18:38.328.521.7";"     ";"78";"8";"";"04 05 06 07 08 09 0A 
0B";"........"
"CAN";"23";"00:18:38.329.448.2";"     ";"77";"8";"";"12 13 14 15 16 17 18 
19";"........"
"CAN";"24";"00:18:38.330.366.7";"     ";"77";"8";"";"13 14 15 16 17 18 19 
1A";"........"
"CAN";"25";"00:18:38.331.285.2";"     ";"77";"8";"";"14 15 16 17 18 19 1A 
1B";"........"
"CAN";"26";"00:18:38.332.211.6";"     ";"77";"8";"";"15 16 17 18 19 1A 1B 
1C";"........"
"CAN";"27";"00:18:38.333.138.1";"     ";"77";"8";"";"16 17 18 19 1A 1B 1C 
1D";"........"
"CAN";"28";"00:18:38.334.071.7";"     ";"77";"8";"";"17 18 19 1A 1B 1C 1D 
1E";"........"
"CAN";"29";"00:18:38.335.029.3";"     ";"78";"8";"";"05 06 07 08 09 0A 0B 
0C";"........"
"CAN";"30";"00:18:38.335.954.9";"     ";"77";"8";"";"18 19 1A 1B 1C 1D 1E 
1F";"........"
"CAN";"31";"00:18:38.336.911.5";"     ";"78";"8";"";"06 07 08 09 0A 0B 0C 
0D";"........"
"CAN";"32";"00:18:38.337.846.0";"     ";"77";"8";"";"19 1A 1B 1C 1D 1E 1F 
20";"....... "
"CAN";"33";"00:18:38.338.803.6";"     ";"78";"8";"";"07 08 09 0A 0B 0C 0D 
0E";"........"
"CAN";"34";"00:18:38.339.738.0";"     ";"77";"8";"";"1A 1B 1C 1D 1E 1F 20 
21";"...... !"
"CAN";"35";"00:18:38.340.694.7";"     ";"78";"8";"";"08 09 0A 0B 0C 0D 0E 
0F";"........"
"CAN";"36";"00:18:38.341.629.2";"     ";"77";"8";"";"1B 1C 1D 1E 1F 20 21 
22";"..... !"""
"CAN";"37";"00:18:38.342.586.8";"     ";"78";"8";"";"09 0A 0B 0C 0D 0E 0F 
10";"........"
"CAN";"38";"00:18:38.343.513.2";"     ";"77";"8";"";"1C 1D 1E 1F 20 21 22 
23";".... !""#"
"CAN";"39";"00:18:38.344.469.9";"     ";"78";"8";"";"0A 0B 0C 0D 0E 0F 10 
11";"........"
"CAN";"40";"00:18:38.345.387.5";"     ";"77";"8";"";"1D 1E 1F 20 21 22 23 
24";"... !""#$"
"CAN";"41";"00:18:38.346.336.2";"     ";"78";"8";"";"0B 0C 0D 0E 0F 10 11 
12";"........"
"CAN";"42";"00:18:38.347.262.7";"     ";"77";"8";"";"1E 1F 20 21 22 23 24 
25";".. !""#$%"
"CAN";"43";"00:18:38.348.211.4";"     ";"78";"8";"";"0C 0D 0E 0F 10 11 12 
13";"........"
"CAN";"44";"00:18:38.349.129.0";"     ";"77";"8";"";"1F 20 21 22 23 24 25 
26";". !""#$%&"
"CAN";"45";"00:18:38.350.077.6";"     ";"78";"8";"";"0D 0E 0F 10 11 12 13 
14";"........"
"CAN";"46";"00:18:38.350.996.1";"     ";"77";"8";"";"20 21 22 23 24 25 26 27";" 
!""#$%&'"
"CAN";"47";"00:18:38.351.945.7";"     ";"78";"8";"";"0E 0F 10 11 12 13 14 
15";"........"
"CAN";"48";"00:18:38.352.878.4";"     ";"78";"8";"";"0F 10 11 12 13 14 15 
16";"........"
"CAN";"49";"00:18:38.353.818.2";"     ";"78";"8";"";"10 11 12 13 14 15 16 
17";"........"
"CAN";"50";"00:18:38.354.720.7";"     ";"77";"8";"";"21 22 23 24 25 26 27 
28";"!""#$%&'("
"CAN";"51";"00:18:38.355.631.2";"     ";"77";"8";"";"22 23 24 25 26 27 28 
29";"""#$%&'()"
"CAN";"52";"00:18:38.356.541.7";"     ";"77";"8";"";"23 24 25 26 27 28 29 
2A";"#$%&'()*"
"CAN";"53";"00:18:38.357.466.4";"     ";"78";"8";"";"11 12 13 14 15 16 17 
18";"........"
"CAN";"54";"00:18:38.358.376.9";"     ";"77";"8";"";"24 25 26 27 28 29 2A 
2B";"$%&'()*+"
"CAN";"55";"00:18:38.359.318.4";"     ";"78";"8";"";"14 15 16 17 18 19 1A 
1B";"........"
"CAN";"56";"00:18:38.360.267.1";"     ";"78";"8";"";"1A 1B 1C 1D 1E 1F 20 
21";"...... !"
"CAN";"57";"00:18:38.361.207.8";"     ";"78";"8";"";"1B 1C 1D 1E 1F 20 21 
22";"..... !"""
"CAN";"58";"00:18:38.362.148.5";"     ";"78";"8";"";"1C 1D 1E 1F 20 21 22 
23";".... !""#"
"CAN";"59";"00:18:38.363.082.1";"     ";"78";"8";"";"1D 1E 1F 20 21 22 23 
24";"... !""#$"
"CAN";"60";"00:18:38.364.013.9";"     ";"78";"8";"";"1E 1F 20 21 22 23 24 
25";".. !""#$%"
"CAN";"61";"00:18:38.364.962.6";"     ";"78";"8";"";"1F 20 21 22 23 24 25 
26";". !""#$%&"
"CAN";"62";"00:18:38.365.894.4";"     ";"78";"8";"";"20 21 22 23 24 25 26 27";" 
!""#$%&'"
"CAN";"63";"00:18:38.366.812.0";"     ";"78";"8";"";"21 22 23 24 25 26 27 
28";"!""#$%&'("
"CAN";"64";"00:18:38.367.736.7";"     ";"78";"8";"";"22 23 24 25 26 27 28 
29";"""#$%&'()"
"CAN";"65";"00:18:38.368.669.4";"     ";"78";"8";"";"23 24 25 26 27 28 29 
2A";"#$%&'()*"
"CAN";"66";"00:18:38.369.595.0";"     ";"78";"8";"";"24 25 26 27 28 29 2A 
2B";"$%&'()*+"
"CAN";"67";"00:18:38.370.520.5";"     ";"78";"8";"";"25 26 27 28 29 2A 2B 
2C";"%&'()*+,"
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core

Reply via email to