David Miller wrote: > From: Wolfgang Grandegger <[email protected]> > Date: Thu, 15 Oct 2009 11:22:18 +0200 > >> + skb->protocol = __constant_htons(ETH_P_CAN); > > Please don't use __constant_htonX() for runtime invocatios. > It's only for situation which must be compile time evaluations > such as case statements and static initializations. > > GCC can figure out that's it's constant if you just use > plan htonX().
OK, I just dent out v2 of this patch. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
