Wolfgang Grandegger wrote: > Wolfram Sang wrote: >> On Thu, Nov 12, 2009 at 02:17:21PM +0100, Wolfgang Grandegger wrote: >> >>> Fine for me. But how do we select the clocks for the MSCAN on the >>> MPC5200? Currently it's implemented as shown below: >>> >>> if (of_get_property(np, "clock-ipb", NULL)) >>> clock_src = MSCAN_CLKSRC_BUS; >>> else >>> clock_src = MSCAN_CLKSRC_XTAL; >>> >>> But we should have something compatible with the MPC512x, e.g.: >>> >>> fsl,mscan-clock-source = "clk-ipb". >> Hmmm, will try to come up with something tomorrow. >> >>> Marc has implemented it for the AT91 CAN. Search for "restart_ms" and >>> "RESTARTED" in "at_can.c" to understand what I'm speaking about. >> Okay, I talked with him and had a try. Could you say if it at least looks not >> totally wrong? If it is at least somewhat the right direction? Then, just the >> clocking-property is left for tomorrow and I will post the final patch and my >> branch. > > Looks good at a first glance. I will test it tomorrow on my MPC5200 > hardware.
Well, to save a test cycle, I'm awaiting for your patch first. Thanks, Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
