Wolfram Sang wrote: > On Fri, Nov 13, 2009 at 01:10:31PM +0100, Wolfgang Grandegger wrote: >> This patch introduces some helper functions to make the code >> more readable, especially the function mscan_rx_poll(). >> Unfortunately, there are still various coding style issue >> which should be fixed for kernel inclusion > > Which ones?
I will review the patch anyhow. > >> Signed-off-by: Wolfgang Grandegger <[email protected]> >> --- >> kernel/2.6/drivers/net/can/mscan/mscan.c | 176 >> ++++++++++++++++--------------- >> 1 file changed, 95 insertions(+), 81 deletions(-) >> >> Index: trunk/kernel/2.6/drivers/net/can/mscan/mscan.c >> =================================================================== >> --- trunk.orig/kernel/2.6/drivers/net/can/mscan/mscan.c >> +++ trunk/kernel/2.6/drivers/net/can/mscan/mscan.c >> @@ -343,6 +343,94 @@ static inline int check_set_state(struct >> return ret; >> } >> >> +static inline void mscan_get_rx_frame(struct net_device *dev, >> + struct can_frame *frame) > > inline is discouraged. There is a paragraph in CodingStyle about it. Yes, of course. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
