On Wed, Dec 9, 2009 at 3:14 PM, Wolfgang Grandegger <[email protected]> wrote:
> Barry Song wrote:
>> On Thu, Nov 12, 2009 at 8:36 PM, Wolfgang Grandegger <[email protected]>
>> wrote:
> [snip]
>>>> diff --git a/drivers/net/can/bfin-can.h b/drivers/net/can/bfin-can.h
>>>> new file mode 100644
>>>> index 0000000..ec74168
>>>> --- /dev/null
>>>> +++ b/drivers/net/can/bfin-can.h
>>> If the header file and the .c gets smaller, please consider merging it
>>> into the .c file.
>>>
>>>> @@ -0,0 +1,162 @@
>>>> +/*
>>>> + * Blackfin On-Chip CAN Driver
>>>> + *
>>>> + * Copyright 2004-2009 Analog Devices Inc.
>>>> + *
>>>> + * Enter bugs at http://blackfin.uclinux.org/
>>>> + *
>>>> + * Licensed under the GPL-2 or later.
>>> See above.
>>>
>>>> + */
>>>> +
>>>> +#ifndef __BLACKFIN_CAN_H
>>>> +#define __BLACKFIN_CAN_H
>>>> +
>>>> +#include <asm/io.h>
>>>> +
>>>> +/*
>>>> + * bfin can private data
>>>> + */
>>>> +struct bfin_can_priv {
>>>> + struct can_priv can; /* must be the first member */
>>>> + struct sk_buff *echo_skb;
>>> Seems not be be used anywhere? It's the same in sja1000.h! Will need to
>>> fix that.
>> echo_skb is used in can_put_echo_skb() and can_get_echo_skb(), example:
>> void can_get_echo_skb(struct net_device *dev, int idx)
>> {
>> struct can_priv *priv = netdev_priv(dev);
>>
>> if (priv->echo_skb[idx]) {
>> netif_rx(priv->echo_skb[idx]);
>> priv->echo_skb[idx] = NULL;
>> }
>> }
>> EXPORT_SYMBOL_GPL(can_get_echo_skb);
>
> Yes, but it does *not* use the member "echo_skb" of the "struct
> bfin_can_priv". Just remove it and see if it harms.
Yes. I must have been cross-eyed.
>
> Wolfgang.
>
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
