Marc Kleine-Budde wrote: > Wolfgang Grandegger wrote: >> Marc Kleine-Budde wrote: >>> Wolfgang Grandegger wrote: >>>> Marc Kleine-Budde wrote: >>>>> Wolfgang Grandegger wrote: >>>>>> Marc Kleine-Budde wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Paul Thomas wrote: >>>>>>>> I saw that the mcp2515 chip supports a one-shot mode. It's just >>>>>>>> setting bit >>>>>>>> 3 (OSM) of the CANCTRL register. I'd mentioned this to Christian, and I >>>>>>>> don't thing setting the register is a big deal, but the issue will be >>>>>>>> setting this mode with ip or some other user space tool. >>>>>>> what about adding the one shot mode to the ctrl_mode? It already holds >>>>>>> the tipple sample and listen-only feature. >>>>>>> >>>>>>> cheers, Marc >>>>>>> >>>>>>> - From 6d17ea182a8e0f86e6ec6c2d673e4bb72616dd50 Mon Sep 17 00:00:00 2001 >>>>>>> From: Marc Kleine-Budde <[email protected]> >>>>>>> Date: Tue, 22 Dec 2009 18:58:06 +0100 >>>>>>> Subject: [PATCH] can/netlink: add CAN_CTRLMODE_ONE_SHOT >>>>>>> >>>>>>> Signed-off-by: Marc Kleine-Budde <[email protected]> >>>>>>> --- >>>>>>> include/linux/can/netlink.h | 1 + >>>>>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>>>>> >>>>>>> diff --git a/include/linux/can/netlink.h b/include/linux/can/netlink.h >>>>>>> index 9ecbb78..c818335 100644 >>>>>>> --- a/include/linux/can/netlink.h >>>>>>> +++ b/include/linux/can/netlink.h >>>>>>> @@ -80,6 +80,7 @@ struct can_ctrlmode { >>>>>>> #define CAN_CTRLMODE_LOOPBACK 0x1 /* Loopback mode */ >>>>>>> #define CAN_CTRLMODE_LISTENONLY 0x2 /* Listen-only mode */ >>>>>>> #define CAN_CTRLMODE_3_SAMPLES 0x4 /* Triple sampling mode */ >>>>>>> +#define CAN_CTRLMODE_ONE_SHOT 0x8 /* One-Shot mode */ >>>>>>> >>>>>>> /* >>>>>>> * CAN device statistics >>>>>> Signed-off-by: Wolfgang Grandegger <[email protected]> >>>>>> >>>>>> I will apply the patch to the SVN trunk. Are you going to prepare a >>>>>> patch for mainline as well? If yes, please post it together with the >>>>>> necessary changes for iproute2, which should be trivial. >>>>> That patch was against v2.6.32, just as a quick shot for illustration :) >>>> It was already perfect. >>> Is this an Acked-by? >> I already added my sob line above. > > To my understanding of Documentation/SubmittingPatches you add your > S-o-b if you submit my patch upstream. Documenting that it went though > your hands. If I submit the patch upstream and you said, that patch is > okay you add your Acked-by: > > Acked-by: is often used by the maintainer of the affected code when that > maintainer neither contributed to nor forwarded the patch.
As a subsystem maintainer I add my signed-off-by, just like David Miller adds his sob thereafter, and so on. But as I'm not maintaining my own tree and forwarding patches that might not be 100% correct. I put Sam on CC. He might be able to clarify the situation. Wolfgang. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
