-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Oliver Hartkopp wrote:
> Wolfgang Grandegger wrote:
>
>>>
>>> + if (skb->len != sizeof(*cf) || cf->can_dlc > 8) {
>>> + kfree_skb(skb);
>>> + dev->stats.tx_dropped++;
>>> + return NETDEV_TX_OK;
>>> + }
>> A static inline function "invalid_can_skb(skb)" (or "no_can_skb") would
>> be handy here:
>>
>> if (invalid_can_skb(skb)) {
>> kfree_skb(skb);
>> dev->stats.tx_dropped++;
>> return NETDEV_TX_OK;
>> }
>
> Another idea could be:
>
> if (can_dropped_invalid_skb(skb, dev))
> return NETDEV_TX_OK;
>
> with
>
> static inline int can_dropped_invalid_skb(struct sk_buff *skb, struct
> net_device *dev)
> {
> const struct can_frame *cf = (struct can_frame *)skb->data;
>
> if (unlikely(skb->len != sizeof(*cf) || cf->can_dlc > 8)) {
> kfree_skb(skb);
> dev->stats.tx_dropped++;
> return 1;
> }
>
> return 0;
> }
this functions looks nice, but I'd swap its arguments, in order to have
the same signature as the alloc_can_skb() functions
cheers, Marc
- --
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAktLd9MACgkQjTAFq1RaXHPaXACfRm0YdKxSPWX8lYudtvnq7WIo
8EMAn1nwRpxJ4mMgD/D4RNwZDT1oO9DY
=t+n5
-----END PGP SIGNATURE-----
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
