Oliver Hartkopp schrieb: > Markus Plessing wrote: >> Replaced the removed cs_error function and fixed other minor issues >> introduced with the following commit in net-next-2.6. >> net-next-2.6 --- commit 5fa9167a1bf5f5a4b7282f5e7ac56a4a5a1fa044 >> >> The new maintainer is set to be the MODULE_AUTHOR and an additional line >> of copyright has been added. >> >> Signed-off-by: Markus Plessing <[email protected]> >> --- > > Hi Markus, > > i have a general problem with this patch. > > Why is it based on net-next-2.6 ?? > > So far the ems_pcmcia driver is only in the SocketCAN SVN.
Hi Oliver, It is rather easy to explain why I've based it on the recent net-next-2.6. Wolfgang stated in an email regarding the esd_usb2 driver, that our driver is broken against recent net-next-2.6. So, I've compiled the driver against it, missing the KERNEL_VERSION macros in first try and broke it for the older ones, but ... > Of course i appreciate that the SocketCAN SVN version is upgraded now. > > Do you have any plans about posting the driver for the 'real' net-next-2.6? > > Looks like you're quite done with the code for mainline. There is nothing to say against getting this driver to mainline. The only thing to mention is, that the product using this driver is not sold anymore because some parts are discontinued by their manufacturers. It may take some time, but there are plans to make a substitute based on express-card standard. I've talked to my boss and he would like to see the driver going mainline. I'm rather new to driver development, so I first have to figure out what I've to do to post the driver for net-next-2.6 ... this may take some days. At least I'll put it on my TODO list ;-) I think there are some naming issues (e.g. dev->dev) ? > Regards, > Oliver > > ps. Regarding the discussion about the module author i can follow Wolf*'s > comments in general. > > But when you plan to take over the development of the driver from Sebastian > inside EMS and he's ok(!) with that, i can imagine that changing the > MODULE_AUTHOR could be reasonable before bringing the driver into mainline. Using MODULE_AUTHOR(xyz and zyx) is a good solution, I think. Regards, Markus _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
