Olaf Hering wrote:
> Some binaries in can-utils depend on features in the socket-can svn
> repository. Building with exported headers from an unpatched kernel will
> fail due to missing symbols or headers.
> 
> This patch adds two make variables to optionally disable building such
> binaries, like this:
> 
> make PROGRAMS_ISOTP= PROGRAMS_CANGW= all
> 
> Signed-off-by: Olaf Hering <[email protected]>
> 
> Index: can-utils-0.svn1152/Makefile
> ===================================================================
> --- can-utils-0.svn1152.orig/Makefile
> +++ can-utils-0.svn1152/Makefile
> @@ -53,10 +53,13 @@ CFLAGS    = -O2 -Wall -Wno-parentheses -
>           -DPF_CAN=29 \
>           -DAF_CAN=PF_CAN
>  
> +PROGRAMS_ISOTP = isotpdump isotprecv isotpsend isotpsniffer isotptun
> +PROGRAMS_CANGW = cangw
>  PROGRAMS = candump cansniffer cansend canplayer canlogserver cangen\
>          canbusload log2long log2asc asc2log bcmserver\
> -        isotpdump isotprecv isotpsend isotpsniffer isotptun\
> -        slcan_attach slcand slcanpty canfdtest cangw
> +        $(PROGRAMS_ISOTP)\
> +        $(PROGRAMS_CANGW)\
> +        slcan_attach slcand slcanpty canfdtest

I also added PROGRAMS_SLCAN as slcan_attach and slcand do not build on Kernels
before 2.6.25 due to the missing LDISC_N_SLCAN definition.

Finally your patches do not change the default behaviour ... which is fine.

Thanks for your contribution.

Regards,
Oliver
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core

Reply via email to