Hi Marc,

On 05/15/2010 08:20 PM, Marc Kleine-Budde wrote:
> Wolfgang Grandegger wrote:
>>>>>>> Feel free to play or even extend it.
>>>>>> I've just found this old mail with this wonderfull tool, can I have you
>>>>>> S-o-b for it?
>>>>> It's actually the algorithm we use in the kernel for calculating
>>>>> bit-timing parameters. Feel free to add my Sob. I have added my most
>>>>> recent version.
>>>> Thanks a lot. I'm planning to put this into the berlios tree. But where
>>>> should it go? can-utils, test,..?
>>> I would put it into can-utils. It is even more a utility than
>>> canfdtest.c :-)
> 
> Fine, then it goes into can-utis. The following patch series integrates
> Wolfgang's tool and fixes some tab vs. space indention mistakes.
> 
> If there'r no objections, I'll dcommit it into berlios svn.
> 
> The patch series can be viewed as as git tree under:
> http://git.pengutronix.de/?p=mkl/berlios-can-utils.git;a=shortlog;h=refs/heads/pu

I would prefer to make the struct can_bittiming_const compatible with
the one used by the kernel:

http://lxr.linux.no/#linux+v2.6.33/drivers/net/can/sja1000/sja1000.c#L75

I forgot to mention that, sorry. Should not be a big deal, though.

Wolfgang.

_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core

Reply via email to