Hi Wolfgang,
so I will remove CAN_CTRLMODE_BERR_REPORTING from ctrlmode_supported again.
Does implementing priv->can.do_get_berr_counter / esd_usb2_get_berr_counter()
still makes sense? I think so - so I will keep it. Do you ack?
BTW, we have a good chance to get a control mechanism (switch) for bit error
reporting in a future firmware version. So this feature will make
it back into the esd_usb2 driver sooner or later.
Matthias
On Tuesday 11 May 2010 16:43, Wolfgang Grandegger wrote:
> Hi Matthias,
>
> On 05/11/2010 03:31 PM, Matthias Fuchs wrote:
> > Hi Wolfgang,
> >
> > first I reduced the receiver list of this discussion to the
> > more CAN related community. When things come to an end I will
> > add netdev and linux-usb again.
>
> OK.
>
> ...
> > This may be right. But we do not have an SJA1000 and the USB2 device
> > automatically reports any change upstream. You do not really have a chance
> > to turn on or off anything. So I only could hide some code when reporting is
> > turned off. But I am not really sure which code exactly.
>
> Ah, I was not aware of that. Bus error reporting might be too heavy on
> some system and therefore we introduced that option to allow the user to
> enable it on demand.
>
> > Should I put some if (priv->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING) {}
> > around these lines in esd_usb2_rx_event()
> > ...
> > } else {
> > priv->can.can_stats.bus_error++;
> > stats->rx_errors++;
> >
> > cf->can_id |= CAN_ERR_PROT | CAN_ERR_BUSERROR;
> > ...
>
> There is no need to hide something. The user can filter bus errors
> anyway. In that case, just do *not* implement berr-reporting.
>
> Wolfgang.
>
>
--
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
Head of System Design
esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Phone: +49-511-37298-0 - Fax: +49-511-37298-68
Please visit our homepage http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Geschäftsführer: Klaus Detering, Dr. Werner Schulze
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core
