Hi Oliver,

On 07/29/2010 11:36 AM, Oliver Hartkopp wrote:
> On 28.07.2010 10:23, Matthias Fuchs wrote:
>> plx_pci/sja1000 + esd_usb2
>>
> 
> Hi Matthias,
> 
> i added a test program to the SVN that checks whether the CAN_RAW_LOOPBACK and
> CAN_RAW_RECV_OWN_MSGS socket options work properly (in can.ko and can-raw-ko
> and vcan.ko).
> 
> So far i was only able to test it on vcan0, as i'm on a business trip and
> don't have a real CAN hardware with me.
> 
> I'll enhance it to force the CAN netdev to be given on the commandline.
> 
> Regarding your request, i was able to see the bad behaviour in the latest
> net-next-2.6. You need to make
> 
>     modprobe vcan echo=1
> 
> before creating vcan devices to test the loopback on driver level!
> 
> Invoking tst-rcv-own-msgs produces this output, which is far away from the
> correct (wanted) output seen in the commit message below.
> 
> sockopt default
>  s : 0
>  t : 0
>  timeout
> sockopt - -
>  timeout
> sockopt - R
>  timeout
> sockopt L -
>  s : 3
>  t : 3
>  timeout
> sockopt L R
>  s : 4
>  t : 4
>  timeout
> done.

I have some comments on the test program. You might understand what the
above output means but even for me it's completely unclear without
looking to the code. Could you please enhance it with more intuitive
output messages. Especially it should be clear if the test passed
successfully or failed.

Thanks,

Wolfgang.
_______________________________________________
Socketcan-core mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-core

Reply via email to